feat(mobile): add compact terminal key layouts - #12934
KoenLemmen wants to merge 1 commit into
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe terminal keyboard accessory changes from one horizontally scrolling toolbar row to a fixed two-row keypad. Three modes provide main, function, and navigation keys. The accessory height increases to 70 pixels, and an ChangesTerminal keypad
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What changed
Replace the mobile terminal's horizontal key scroller with a compact, two-row grid.
FNswitches between the default, function-key, and navigation layouts.Existing key handlers, modifier state, keyboard control, and terminal theme colors remain unchanged.
Why
The current toolbar splits common keys across scroll positions. The fixed grid keeps common controls and the arrow cluster visible, gives each key a stable position, and adds function and navigation keys while increasing the accessory height by 18 points.
UI changes
Watch the dark-mode
FNinteraction (11 seconds)Validation
vp run --filter @t3tools/mobile typecheckgit diff --checkChecklist
Model: GPT-5.6 Sol. Harness: Codex in T3 Code.
Summary by CodeRabbit
New Features
Improvements