Skip to content

feat(mobile): add compact terminal key layouts - #12934

Open
KoenLemmen wants to merge 1 commit into
pingdotgg:mainfrom
KoenLemmen:feat/mobile-terminal-key-layouts
Open

KoenLemmen wants to merge 1 commit into
pingdotgg:mainfrom
KoenLemmen:feat/mobile-terminal-key-layouts

Conversation

@KoenLemmen

@KoenLemmen KoenLemmen commented Sep 21, 2026

Copy link
Copy Markdown

What changed

Replace the mobile terminal's horizontal key scroller with a compact, two-row grid. FN switches between the default, function-key, and navigation layouts.

Existing key handlers, modifier state, keyboard control, and terminal theme colors remain unchanged.

Why

The current toolbar splits common keys across scroll positions. The fixed grid keeps common controls and the arrow cluster visible, gives each key a stable position, and adds function and navigation keys while increasing the accessory height by 18 points.

UI changes

Before Before, scrolled
Default Function keys Navigation keys

Watch the dark-mode FN interaction (11 seconds)

Validation

  • vp run --filter @t3tools/mobile typecheck
  • Targeted lint, formatting, and git diff --check
  • Pixel 6 emulator on Android 15
  • Verified all layouts, modifiers, paste, keyboard control, and terminal theme colors

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots
  • I included an interaction video

Model: GPT-5.6 Sol. Harness: Codex in T3 Code.

Summary by CodeRabbit

  • New Features

    • Rebuilt the terminal keyboard accessory as a fixed two-row keypad for easier access.
    • Added main, function, and navigation modes with an “fn” button for switching layouts.
    • Added visual states for active modifiers, icons, labels, and key dividers.
  • Improvements

    • Expanded the accessory height to provide a more spacious terminal control layout.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 21, 2026
@KoenLemmen
KoenLemmen marked this pull request as ready for review September 21, 2026 18:15
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4873af6a-11dd-450d-9f87-607dc7ee92d1

📥 Commits

Reviewing files that changed from the base of the PR and between 371b52d and f37e753.

📒 Files selected for processing (1)
  • apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The terminal keyboard accessory changes from one horizontally scrolling toolbar row to a fixed two-row keypad. Three modes provide main, function, and navigation keys. The accessory height increases to 70 pixels, and an fn button cycles modes.

Changes

Terminal keypad

Layer / File(s) Summary
Define keypad layouts and buttons
apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx
The screen adds three toolbar modes, fixed seven-action rows, ANSI key sequences, platform theme typing, and a themed TerminalAccessoryButton.
Integrate mode state and rendering
apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx
The screen stores the active mode, builds platform-specific layouts, increases the accessory height from 52 to 70, and renders two fixed rows with fn and dismiss controls.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding compact terminal key layouts for mobile.
Description check ✅ Passed The description explains what changed, why it changed, and the UI impact. It includes before/after screenshots, an interaction video, validation details, and a completed checklist.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant