Skip to content

fix(mobile): review dictated drafts without opening the keyboard - #12917

Open
Dwite wants to merge 3 commits into
pingdotgg:mainfrom
Dwite:t3code/fix-voice-composer-expansion
Open

Dwite wants to merge 3 commits into
pingdotgg:mainfrom
Dwite:t3code/fix-voice-composer-expansion

Conversation

@Dwite

@Dwite Dwite commented Sep 21, 2026

Copy link
Copy Markdown

What Changed

After dictation finishes, expand the mobile composer into its full-height reading area without focusing the editor or opening the keyboard. Tap the text to edit, or tap the conversation to collapse it. Successful sends clear the review state.

Why

A transcript completed from the collapsed composer stayed in one line. Review should make the text readable without immediately opening the keyboard. The review state is scoped to the thread, with matching feed spacing and safe-area padding.

UI Changes

Before After
Transcript remains in one line Expanded transcript with the keyboard hidden

Before/after video

Verified on an iOS 26.5 simulator with temporary simulated recorder and transcript responses. Real microphone capture and speech recognition were not tested. All fixtures were removed before committing.

Validation

  • 29 focused voice-input tests pass; mobile TypeScript and formatting checks pass.
  • Changed-file lint completes with warnings in existing code.
  • Device check: 160-point reading area with no keyboard, tap-to-edit with keyboard, and tap-outside collapse to 36 points.

The new-task composer already uses an expanded editor. This change is in the existing-thread mobile UI and applies independently of provider and connection mode.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-6. Harness: Codex.

Summary by CodeRabbit

  • New Features
    • Added a dictation review state to thread composition.
    • Voice-dictated drafts remain expanded for easier review, with increased editor space.
    • Review status clears when the composer is focused, collapsed, or the message is sent.
    • Improved handling of bottom spacing while composing on iOS.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 21, 2026
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Sep 21, 2026
@Dwite Dwite changed the title fix(mobile): expand composer after dictation fix(mobile): review dictated drafts without opening the keyboard Sep 21, 2026
@Dwite
Dwite marked this pull request as ready for review September 21, 2026 14:44
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 77a03087-d443-49c2-a30b-d59482514f1b

📥 Commits

Reviewing files that changed from the base of the PR and between 1de563c and da0fd15.

📒 Files selected for processing (2)
  • apps/mobile/src/features/threads/ThreadComposer.tsx
  • apps/mobile/src/features/threads/ThreadDetailScreen.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Dictation review flow

Layer / File(s) Summary
Composer review contract and layout
apps/mobile/src/features/threads/ThreadComposer.tsx
ThreadComposer accepts dictation review state and a completion callback. Draft updates invoke the callback. The composer remains expanded during review, and the editor minimum height becomes 160.
Screen review lifecycle and sizing
apps/mobile/src/features/threads/ThreadDetailScreen.tsx
ThreadDetailScreen tracks review state per thread, selects review chrome, clears state on focus, send, or collapse, and applies the iOS bottom inset only while the composer is focused.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant VoiceInputController
  participant ThreadComposer
  participant ThreadDetailScreen
  VoiceInputController->>ThreadComposer: update draft message
  ThreadComposer->>ThreadDetailScreen: call onDictationComplete()
  ThreadDetailScreen->>ThreadComposer: set review state and select review chrome
  ThreadComposer->>ThreadComposer: remain expanded with minHeight 160
Loading

Suggested reviewers: juliusmarminge

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes all required sections. It clearly explains the change, the reason, the UI impact, validation results, and interaction evidence. The checklist is complete.
Title check ✅ Passed The title clearly and concisely describes the main change: reviewing dictated drafts without opening the keyboard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant