Conversation
Dwite
marked this pull request as ready for review
September 21, 2026 14:44
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesDictation review flow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant VoiceInputController
participant ThreadComposer
participant ThreadDetailScreen
VoiceInputController->>ThreadComposer: update draft message
ThreadComposer->>ThreadDetailScreen: call onDictationComplete()
ThreadDetailScreen->>ThreadComposer: set review state and select review chrome
ThreadComposer->>ThreadComposer: remain expanded with minHeight 160
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
After dictation finishes, expand the mobile composer into its full-height reading area without focusing the editor or opening the keyboard. Tap the text to edit, or tap the conversation to collapse it. Successful sends clear the review state.
Why
A transcript completed from the collapsed composer stayed in one line. Review should make the text readable without immediately opening the keyboard. The review state is scoped to the thread, with matching feed spacing and safe-area padding.
UI Changes
Before/after video
Verified on an iOS 26.5 simulator with temporary simulated recorder and transcript responses. Real microphone capture and speech recognition were not tested. All fixtures were removed before committing.
Validation
The new-task composer already uses an expanded editor. This change is in the existing-thread mobile UI and applies independently of provider and connection mode.
Checklist
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit