Conversation
Keep live tool-group identity across a steer so LegendList does not remount the row at the 90px estimate. Pin chrome sizes, leave agent-spawn work-live unpinned, and remasure via extraData when expanded groups grow or spawn details expand. Co-authored-by: maco <macodev00@users.noreply.github.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR makes a localized fix to existing web timeline virtualization: it preserves live-row identity and remasures variable-height streaming groups to prevent overlap. It adds focused regression tests without changing product defaults, APIs, security-sensitive code, or static-analysis settings. You can add or adjust custom eligibility rules. Learn more. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe timeline keeps live activity rows stable across mid-turn steers. LegendList now uses row-specific fixed sizes and height signatures that include expanded activity and spawn content. ChangesTimeline overlap and row sizing
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What
work-liverows (unpinned fixed size) and remasuring when spawn expand changes.Why
Fixes #12094
Redo of closed #12734 addressing Macroscope Not-approved / Medium: mechanical LegendList sizing +
expandedSpawnEntryIdsin list extraData; avoid oversized layout policy rewrite.UI
Desktop chat timeline: live agent-spawn expand should not overlap the following Working row.
Checklist
Summary by CodeRabbit