fix(web): Antigravity Sign-in required UI + Sign in with Google by macodev00 · Pull Request #12908 · pingdotgg/t3code

macodev00 · 2026-09-21T13:03:02Z

What

Settings treats healthy Antigravity + unchecked Google auth as Installed · Sign-in required (no amber Needs attention), without changing the health probe to ready or cached-model retention.
Adds Sign in with Google on the Antigravity provider settings list row and selected card, starting existing startProviderAuth OAuth.

Why

Redo of closed #12861 addressing Macroscope Not-approved (readiness semantics): UI-only framing; probe/registry contracts unchanged.

UI

Settings → Providers → Antigravity: informational sign-in-required copy; Sign in with Google on list row and selected card.

Checklist

I read CONTRIBUTING.md and kept this small / bug-only
What + why explained above
Followed AGENTS.md documentation rules (no new docs)
No unrelated changes
CLA / AI-reviewed standing override for macodev00 auto-contrib

Summary by CodeRabbit

New Features
- Added Google sign-in for eligible Antigravity provider instances directly from provider settings.
- Sign-in is available in both provider list and editor views.
Bug Fixes
- Providers awaiting Google authentication now show “Installed · Sign-in required” instead of “Needs attention.”
- Genuine warnings and errors continue to display their appropriate status indicators and messages.
Tests
- Added coverage for sign-in actions, pending authentication, provider states, and status messaging.

Treat a healthy Antigravity install with unchecked Google auth as informational in Settings (Installed · Sign-in required) instead of amber Needs attention. Keep the server health probe as warning so readiness semantics stay unchanged. Add a Sign in with Google action on the Antigravity settings card that starts the existing OAuth flow. Co-authored-by: maco <macodev00@users.noreply.github.com>

Co-authored-by: maco <macodev00@users.noreply.github.com>

macroscopeapp · 2026-09-21T13:05:13Z

+        onStarted?.();
+        pendingRef.current = true;
+        setPending(true);
+        void startAuth(target).finally(() => {


🟡 Medium settings/ProviderSetupSection.tsx:136

When startAuth(target) returns a setup failure, this handler discards the AtomCommandResult, so the button simply becomes enabled again without showing an error. Because both failure reporters are disabled, stale-provider cases such as a removed instance fail silently; remove those reporter overrides or explicitly surface the command failure.

🤖 Copy this AI Prompt to have your agent fix this:

In file @apps/web/src/components/settings/ProviderSetupSection.tsx around line 136: When `startAuth(target)` returns a setup failure, this handler discards the `AtomCommandResult`, so the button simply becomes enabled again without showing an error. Because both failure reporters are disabled, stale-provider cases such as a removed instance fail silently; remove those reporter overrides or explicitly surface the command failure.

macroscopeapp · 2026-09-21T13:06:21Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new Google OAuth entry point and changes authentication-related provider status behavior in production settings. The new action also suppresses setup failures, so stale-provider errors may be invisible to users until the failure handling is addressed.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-21T13:10:23Z

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 845d7ead-4ae8-4975-9a75-b0c9f7ed30c4

📥 Commits

Reviewing files that changed from the base of the PR and between 1de563c and ca0267c.

📒 Files selected for processing (7)

apps/web/src/components/settings/ProviderInstanceCard.test.ts
apps/web/src/components/settings/ProviderInstanceCard.tsx
apps/web/src/components/settings/ProviderSettingsPanel.tsx
apps/web/src/components/settings/ProviderSetupSection.test.tsx
apps/web/src/components/settings/ProviderSetupSection.tsx
apps/web/src/components/settings/providerStatus.test.ts
apps/web/src/components/settings/providerStatus.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

Antigravity providers with unchecked Google authentication now show “Installed · Sign-in required” instead of “Needs attention”. Eligible provider cards display a “Sign in with Google” action that starts the existing OAuth flow in list, editor, and setup views.

Changes

Antigravity sign-in experience

Layer / File(s)	Summary
Informational unchecked-auth status `apps/web/src/components/settings/providerStatus.ts`, `apps/web/src/components/settings/providerStatus.test.ts`	Unchecked authentication is identified separately. Its summary uses “Installed · Sign-in required”, while confirmed sign-out and other warning states retain their existing summaries.
Google sign-in control `apps/web/src/components/settings/ProviderSetupSection.tsx`, `apps/web/src/components/settings/ProviderSetupSection.test.tsx`	Browser-based Antigravity methods expose `AntigravityGoogleSignInButton`. The button starts authentication, disables during loading or active authentication, and is omitted for API-key or authenticated providers.
Provider card integration `apps/web/src/components/settings/ProviderSettingsPanel.tsx`, `apps/web/src/components/settings/ProviderInstanceCard.tsx`, `apps/web/src/components/settings/ProviderInstanceCard.test.ts`	The settings panel supplies the sign-in action to provider cards. List and editor cards render it, and unchecked Antigravity authentication no longer shows the warning dot, attention styling, or “Needs attention” state.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix · Severity of issue fixed: Low

Sequence Diagram(s)

sequenceDiagram
  participant ProviderSettingsPanel
  participant ProviderInstanceCard
  participant AntigravityGoogleSignInButton
  participant startProviderAuth
  ProviderSettingsPanel->>AntigravityGoogleSignInButton: render when provider and auth method are eligible
  ProviderSettingsPanel->>ProviderInstanceCard: pass signInAction
  ProviderInstanceCard->>AntigravityGoogleSignInButton: render in list or editor mode
  AntigravityGoogleSignInButton->>startProviderAuth: start Google OAuth
  startProviderAuth-->>AntigravityGoogleSignInButton: update authentication state

Suggested reviewers: t3dotgg

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 72.73% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 7 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main changes: the Antigravity sign-in-required UI and the new Google sign-in action.
Description check	✅ Passed	The description explains what changed, why it changed, the affected UI, issue context, and scope constraints. It is mostly complete, although it does not include the template-requested screenshots or …
Linked Issues check	✅ Passed	The PR meets the coding requirements in [`#12751`] and [`#12861`]. `isAntigravityUncheckedAuth` identifies installed Antigravity providers with warning status and unknown auth, and `getProviderSummary` re…
Out of Scope Changes check	✅ Passed	The changes stay within [`#12751`] and [`#12861`]. The new helpers, button, card wiring, status rendering, and automated tests directly implement the requested Antigravity status and Google sign-in behavi…

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

cursoragent and others added 2 commits September 21, 2026 12:58

style(web): format Antigravity settings sign-in status markup

ca0267c

Co-authored-by: maco <macodev00@users.noreply.github.com>

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 21, 2026

macroscopeapp Bot reviewed Sep 21, 2026

View reviewed changes

Navigation Menu

fix(web): Antigravity Sign-in required UI + Sign in with Google - #12908

fix(web): Antigravity Sign-in required UI + Sign in with Google#12908
macodev00 wants to merge 2 commits into
pingdotgg:mainfrom
macodev00:cursor/antigravity-signin-settings-c98f

macodev00 commented Sep 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

macroscopeapp Bot Sep 21, 2026

Uh oh!

macroscopeapp Bot commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

macodev00 commented Sep 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

UI

Checklist

Summary by CodeRabbit

Uh oh!

macroscopeapp Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot commented Sep 21, 2026

Approvability

Uh oh!

coderabbitai Bot commented Sep 21, 2026

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

macodev00 commented Sep 21, 2026 •

edited by coderabbitai Bot

Loading