fix(replication-restore): adjust retain latest mvcc fallback#6972
fix(replication-restore): adjust retain latest mvcc fallback#6972RidRisR wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
@Leavrth: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Leavrth The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@RidRisR: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What changed
--replicationRetainLatestMVCCVersion, defaulting to true, to control whether replication restore passes BR--retain-latest-mvcc-version.--retain-latest-mvcc-versionwhen that option is false.--replicationRetainLatestMVCCVersion=falsefor log restore whenCompactSettled=Truebut the compact result reason is notAllShardsComplete.Why
When compact backup does not fully complete, phase-2 log restore should fall back without retaining latest MVCC versions. The controller already gates phase-2 on
RestoreCompactSettled; this change uses that marker reason to choose the BR argument while keeping the existing default behavior for successful and manual replication restore paths.Validation
git diff --check upstream/release-1.x..HEAD GOCACHE=/tmp/tidb-operator-go-cache go test -count=1 ./cmd/backup-manager/app/cmd ./cmd/backup-manager/app/restore ./pkg/backup/restore