eventservice: scope mounter by changefeed - #6337
asddongmen wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe event service now creates a separate event mounter for each changefeed. Scanning uses the changefeed-scoped mounter. Tests verify distinct mounters for different changefeeds and shared status for replicas. ChangesIntegrity mounter scope
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to Integrity checks now use each changefeed’s own configuration, avoiding cross-changefeed configuration reuse. The change is mergeable. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops through changefeed light Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #6334
When multiple changefeeds share an upstream cluster, EventService reused the mounter configured by the first registered changefeed. Integrity checks for later changefeeds therefore depended on registration order.
What is changed and how it works?
Move the mounter from the cluster-scoped event broker to changefeed status. It is initialized from that changefeed integrity configuration and used by all of its dispatcher scans. A unit test verifies different changefeeds receive distinct mounters.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. Broker sharing, dispatcher protocol, and integrity configuration format are unchanged.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit