Skip to content

i18n(ja): fix loose wording and stray artifact in binlog_do_db/binlog_ignore_db troubleshooting - #23840

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-binlog-do-db-similar-message-wording
Open

i18n(ja): fix loose wording and stray artifact in binlog_do_db/binlog_ignore_db troubleshooting#23840
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-binlog-do-db-similar-message-wording

Conversation

@yahonda

@yahonda yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Two defects in the same troubleshooting section (binlog_do_db/binlog_ignore_db error messages):

  1. に似ている場合 (casual "looks similar") is too loose for a technical description of pattern matching against a placeholder-style error message (xxx stands for actual DB names). Changed to に類似している場合, matching the technical register.
  2. A stray literal -- was left between two sentences, right before the See [--binlog-do-db=db_name] / See [--binlog-ignore-db=db_name] links. The EN source has no such character here; it appears to be an MT artifact from a dropped "See". Removed it.

Searched the rest of the i18n-ja-release-8.5 corpus for the same stray--- artifact pattern and found one more instance of the identical defect:

  1. tiup/tiup-component-dm-template.md (summary: frontmatter): the EN source's "The --full option ..." had "The" collapsed into a literal -- stranded right before the real --full flag name. Removed the stray token.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Improved Japanese wording in the troubleshooting guide.
    • Corrected formatting for MySQL option links.

…_ignore_db troubleshooting

- Replace casual 似ている (looks similar) with the more precise 類似している,
  matching the technical register expected for a pattern-match description.
- Remove a stray literal "--" left over between two sentences (the EN source
  has no such character; likely an MT artifact from a dropped "See").

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c7e92836-441e-4926-8eab-8f0895a27a70

📥 Commits

Reviewing files that changed from the base of the PR and between 645c2ff and a290ea4.

📒 Files selected for processing (1)
  • tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates two Japanese bullet points in the TiDB Cloud DM troubleshooting guide. It replaces “に似ている” with “に類似している” and removes stray dashes before two MySQL option links.

Changes

Documentation wording cleanup

Layer / File(s) Summary
Wording and link formatting
tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md
Two bullet points use the revised Japanese wording and no longer contain stray dashes before the --binlog-do-db=db_name and --binlog-ignore-db=db_name links.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to a290e

This documentation-only cleanup introduces no material runtime or user-facing product risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the Japanese localization scope and the wording and artifact fixes in the binlog troubleshooting documentation.
Description check ✅ Passed The description includes the required change summary, affected version, AI involvement, and applicable change-type checkboxes. It provides specific technical details for the documented fixes.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…late summary

Same MT artifact as the binlog_do_db/binlog_ignore_db fix in this PR: the EN
source's "The --full option ..." had "The" collapsed into a literal "--"
left stranded right before the real --full flag name.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant