releases: fix transaction_atomicity spelling to match the TOML config key - #23839
releases: fix transaction_atomicity spelling to match the TOML config key#23839yahonda wants to merge 1 commit into
Conversation
… key Verified against a live TiCDC changefeed (v8.5.8): [sink] transaction-atomicity (hyphen) in the TOML config file is accepted, while transaction_atomicity (underscore) is rejected with 'contained unknown configuration options: sink.transaction_atomicity'. The underscore form is the OpenAPI v2 JSON field name (cdc/api/v2/model.go), a different surface from the TOML config file this release note is about (pkg/config/sink.go uses the hyphenated toml tag).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe TiCDC bug-fix entry in the 6.6.0 release notes now uses ChangesRelease note parameter naming
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This documentation-only change has no runtime impact and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
release-6.6.0.md's changelog entry for issue #7935 says `transaction_atomicity` (underscore), but this specific fix was about the field failing to update via the configuration file — and the TOML config file field is `transaction-atomicity` (hyphen). The same historical changelog entry appears in release-6.1.4.md and release-6.5.1.md, both already correctly spelled with a hyphen; only release-6.6.0.md has the underscore typo.
Verification:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
transaction-atomicityandprotocol.