dm: fix filter to filters to match the field name used elsewhere - #23838
dm: fix filter to filters to match the field name used elsewhere#23838yahonda wants to merge 1 commit into
Conversation
The task configuration file field is documented as filters (plural) throughout DM docs, e.g. task-configuration-file-full.md's #### `filters` heading, and the YAML example immediately following this sentence.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
"add a `filter` to the task configuration file of DM" uses the singular `filter`, but the field name is `filters` (plural) — as shown in the very next code block in this same file, and documented via the `#### `filters` {#filters}` heading in `dm/task-configuration-file-full.md`.
Source-code verification: `dm/config/task.go` defines the field as `Filters map[string]*bf.BinlogEventRule `yaml:"filters" toml:"filters" json:"filters"`` — confirming `filters` (plural) is the actual field name recognized by DM, in both the YAML task config and its TOML/JSON representations.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?