br: clarify that the Azure AD systemd step edits the service config, not TiKV's config file - #23835
br: clarify that the Azure AD systemd step edits the service config, not TiKV's config file#23835yahonda wants to merge 1 commit into
Conversation
…'s config file The systemctl edit tikv-24000 command in the preceding step opens a systemd unit drop-in, not tikv.toml. The same document's newer "managed identity" section already describes this correctly as opening the systemd service editor.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Azure Blob Storage authentication documentation now directs TiKV users to configure Azure AD environment variables through the systemd service configuration. ChangesAzure authentication documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The revised instructions clarify the existing systemd configuration workflow and introduce no merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
In "Method 3: Use Azure AD for backup and restore", the step that runs
systemctl edit tikv-24000was followed by "Edit the TiKV configuration file to configure the three environment variables", which is inaccurate:systemctl editopens a systemd unit drop-in override, not TiKV's own configuration file (tikv.toml).The same document's newer "Method 4: Use Azure managed identities" section already describes the identical
systemctl edit tikv-24000step correctly, as "Open the systemd service editor". This PR aligns the older section's wording with the already-correct newer section.Source-code verification: TiUP's systemd unit template (
embed/templates/systemd/system.service.tpl) shows the[Service]section only runsrun_tikv.shviaExecStart— the unit itself has no reference totikv.toml. TiKV's actual config file path is passed as a--configflag insiderun_tikv.sh, a separate file untouched bysystemctl edit. This confirmssystemctl edit tikv-24000can only ever modify the systemd service configuration (e.g. addEnvironment=lines), never TiKV's own configuration file.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?