fix(build): pin Shadow plugin's vulnerable build-time deps (CVE-2024-47554, CVE-2025-67030)#223
Open
joerg84 wants to merge 1 commit into
Open
fix(build): pin Shadow plugin's vulnerable build-time deps (CVE-2024-47554, CVE-2025-67030)#223joerg84 wants to merge 1 commit into
joerg84 wants to merge 1 commit into
Conversation
The Shadow 8.1.1 Gradle plugin pulls vulnerable transitives onto the plugin (buildscript) classpath. These run only in the Gradle build JVM and are NOT part of the published artifact, but they trip Dependabot high alerts: - commons-io 2.11.0 -> CVE-2024-47554 (fixed in 2.14.0) - plexus-utils 3.5.1 -> CVE-2025-67030 (fixed in 3.6.1) Force patched versions on the buildscript classpath (commons-io 2.18.0, plexus-utils 3.6.1). This stays on Shadow 8.1.1, so the Java 8 CI matrix is unaffected. shadowJar still builds and all unit tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the two remaining HIGH Dependabot alerts on
build.gradle, both from build-time-only transitives of the Shadow 8.1.1 Gradle plugin:commons-io2.11.0org.codehaus.plexus:plexus-utils3.5.1Context — these are not in the shipped artifact
./gradlew buildEnvironmentshows both come fromcom.github.johnrengelman:shadow:8.1.1on the buildscript (plugin) classpath. They execute only in the Gradle build JVM duringshadowJarand are not dependencies of the publishedpinecone-client(they don't appear onruntimeClasspathor in the published POM). So real-world exposure is limited to the build environment — but Dependabot still flags them, so this pins them to patched versions.Approach
Force patched versions on the buildscript classpath via a
buildscript { configurations.classpath { resolutionStrategy { force ... } } }block. This intentionally keeps Shadow at 8.1.1 — upgrading the Shadow plugin would be the alternative, but the Java 8 CI matrix limits us tocom.gradleup.shadow≤ 8.3.1 and carries coordinate/DSL changes, so a targeted force is lower-risk for a build-tooling fix.Verification
./gradlew buildEnvironment→commons-io 2.11.0 -> 2.18.0,plexus-utils 3.5.1 -> 3.6.1../gradlew clean build→shadowJarruns, BUILD SUCCESSFUL, 90/90 unit tests pass (JDK 17, Gradle 8.5).Related
Third of three CVE-remediation PRs: #221 (jackson, runtime), #222 (netty, runtime), and this one (build-time tooling).
🤖 Generated with Claude Code
Note
Low Risk
Build-only Gradle classpath overrides with no change to runtime dependencies or published library contents; Shadow plugin version is unchanged.
Overview
Adds a
buildscriptblock that forces patched versions of Shadow 8.1.1’s transitive buildscript classpath dependencies:commons-io→ 2.18.0 (CVE-2024-47554) andplexus-utils→ 3.6.1 (CVE-2025-67030). Inline comments document that these run only in the Gradle build JVM during tasks likeshadowJar, not in the publishedpinecone-clientartifact.Shadow remains at 8.1.1; the change is classpath resolution only, intended to clear Dependabot alerts without upgrading the Shadow plugin.
Reviewed by Cursor Bugbot for commit 78c64b3. Bugbot is set up for automated code reviews on this repo. Configure here.