Repository navigation
[Docs] The Studio Example Bundle now ships its build as an archive - #4124
Merged
Merged
Conversation
The Example Bundle moved from a committed public/build/ directory to a committed build-dist/build-<id>.zip (pimcore/studio-example-bundle#40), so it is no longer an example of the "commit the expanded build directory" option, and the provider linked from Registering the Frontend Build is no longer a plain provider. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documentation depends on external PR pimcore/studio-example-bundle#40, which has not yet merged.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Updates frontend-build documentation to reflect the Studio Example Bundle’s planned archive-based distribution.
Changes:
- Reclassifies the Example Bundle under committed build archives.
- Links service tagging guidance to its
services.yaml.
| File | Description |
|---|---|
doc/04_Extending/04_Shipping_the_Frontend_Build_as_an_Archive.md |
Updates archive-shipping examples. |
doc/04_Extending/03_Registering_the_Frontend_Build.md |
Revises the Example Bundle reference. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ValeriaMaltseva
marked this pull request as draft
September 22, 2026 09:30
ValeriaMaltseva
marked this pull request as ready for review
September 30, 2026 14:00
pimcore/studio-example-bundle#40 added the build-id logic above the entry config, moving `main: './js/src/main.ts'` from line 49 to line 59. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to pimcore/studio-example-bundle#40, which rolls out the packaged frontend-build
(zip archive + warmup extraction) to the Studio Example Bundle — see pimcore/platform-version#501.
Two statements in the Extending docs stop being true once that merges:
04_Shipping_the_Frontend_Build_as_an_Archive.mdpresents the Example Bundle as the example ofthe "commit the expanded build directory" option. It is now an example of the third option, the
committed archive, so it moves to that bullet.
03_Registering_the_Frontend_Build.mdlinks to the Example Bundle'ssrc/Webpack/WebpackEntryPointProvider.phpas "a complete working example" of the plain providerdescribed on that page. That class now implements
BuildArchiveProviderInterfaceviaBuildArchiveExtractionTrait. The link moves to the bundle'sconfig/services.yaml, which is stilla faithful example of the tagging the page is about, with a pointer to page 04 for the class itself.
Docs only — no code changes.
🤖 Generated with Claude Code