Skip to content

Set default partition filesystem to null and add unit tests for it - #112

Merged
landerweit-phytec merged 4 commits into
mainfrom
wip-gpt-null-filesystem
Jul 16, 2026
Merged

Set default partition filesystem to null and add unit tests for it#112
landerweit-phytec merged 4 commits into
mainfrom
wip-gpt-null-filesystem

Conversation

@mschwan-phytec

Copy link
Copy Markdown
Collaborator

Fix function declaration style for check_partition_alignment().

The default filesystem for partitions is now null, instead of fat32. This is now in line with the documentation, which has been using null, too.

Add a new test for checking all supported partition filesystems, including null and the default value, which should now also be null.

Fix function declaration style for check_partition_alignment().

Signed-off-by: Martin Schwan <m.schwan@phytec.de>
The default filesystem for partitions is now null, instead of fat32.
This is now in line with the documentation, which has been using null,
too.

Signed-off-by: Martin Schwan <m.schwan@phytec.de>
Add a new test for checking all supported partition filesystems,
including null and the default value, which should now also be null.

Signed-off-by: Martin Schwan <m.schwan@phytec.de>
@landerweit-phytec

Copy link
Copy Markdown
Collaborator

The documentation does not mention any default for the filesystem. null is not mentioned at all. https://partup.readthedocs.io/en/latest/layout-config-reference.html#partitions

@landerweit-phytec

Copy link
Copy Markdown
Collaborator

Code and test look good.

@mschwan-phytec

Copy link
Copy Markdown
Collaborator Author

The documentation does not mention any default for the filesystem. null is not mentioned at all. https://partup.readthedocs.io/en/latest/layout-config-reference.html#partitions

Right. I could swear I read it in that section as well.

What I had in mind was probably this: https://partup.readthedocs.io/en/latest/layout-config-reference.html#supported-file-types See the ext[234] description:

This overrides any existing filesystem, so it should be specified as filesystem: null or not be specified at all.

This implies the default would be null. You are right, the documentation doesn't explicitly mention this. I'll make this more clear in an additional commit.

Describe the now default filesystem type "null" and when to use it. Add
a note, that the default changed with version 4.0.0.

Signed-off-by: Martin Schwan <m.schwan@phytec.de>
@landerweit-phytec
landerweit-phytec merged commit b43baaf into main Jul 16, 2026
4 checks passed
@landerweit-phytec
landerweit-phytec deleted the wip-gpt-null-filesystem branch July 16, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants