Repository navigation
Ignore unused function params prefixed with _ - #6743
Merged
Merged
Conversation
staabm
reviewed
Oct 18, 2026
staabm
reviewed
Oct 18, 2026
staabm
reviewed
Oct 18, 2026
bpfoley
force-pushed
the
2.3.x
branch
3 times, most recently
from
October 18, 2026 13:00
aa57bb7 to
a4e576f
Compare
Like variable assignment in UnusedVariableRule and similar to Rust, Python, and GoLang linting rules: Go treats arguments named `_` as dummy arguments. Rust uses the same rule for unused variables and function params. Python's ruff uses _prefix for unused-function-argument - https://docs.astral.sh/ruff/rules/unused-function-argument/ - https://doc.rust-lang.org/stable/rustc/lints/listing/warn-by-default.html#unused-variables - https://tip.golang.org/gopls/analyzers#unusedparams Fixes phpstan/phpstan#15480
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like variable assignment in UnusedVariableRule and similar to Rust, Python, and GoLang linting rules:
Go treats arguments named
_as dummy arguments.Rust uses the same rule for unused variables and function params. Python's ruff uses _prefix for unused-function-argument
Fixes phpstan/phpstan#15480