Skip to content

Remove last unused variables in catch() #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AJenbo wants to merge 1 commit into
base: 2.2.x
Choose a base branch
from
+10 −5
Open

Remove last unused variables in catch() #6305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Type/Php/DateIntervalConstructorThrowTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use PHPStan\Type\ObjectType;
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
use Throwable;
use function count;

#[AutowiredService]
Expand Down Expand Up @@ -40,7 +41,7 @@ public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflect
foreach ($constantStrings as $constantString) {
try {
new DateInterval($constantString->getValue());
} catch (\Exception $e) { // phpcs:ignore
} catch (Throwable) {
return $this->exceptionType();
}

Expand Down
3 changes: 2 additions & 1 deletion src/Type/Php/DateTimeConstructorThrowTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use PHPStan\Type\ObjectType;
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
use Throwable;
use function count;
use function in_array;

Expand Down Expand Up @@ -42,7 +43,7 @@ public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflect
foreach ($constantStrings as $constantString) {
try {
new DateTime($constantString->getValue());
} catch (\Exception $e) { // phpcs:ignore
} catch (Throwable) {
return $this->exceptionType();
}

Expand Down
3 changes: 2 additions & 1 deletion src/Type/Php/DateTimeModifyMethodThrowTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use PHPStan\Type\ObjectType;
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
use Throwable;
use function count;
use function in_array;

Expand Down Expand Up @@ -47,7 +48,7 @@ public function getThrowTypeFromMethodCall(MethodReflection $methodReflection, M
try {
$dateTime = new DateTime();
$dateTime->modify($constantString->getValue());
} catch (\Exception $e) { // phpcs:ignore
} catch (Throwable) {
return $this->exceptionType();
}

Expand Down
3 changes: 2 additions & 1 deletion src/Type/Php/DateTimeZoneConstructorThrowTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use PHPStan\Type\ObjectType;
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
use Throwable;
use function count;

#[AutowiredService]
Expand Down Expand Up @@ -40,7 +41,7 @@ public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflect
foreach ($constantStrings as $constantString) {
try {
new DateTimeZone($constantString->getValue());
} catch (\Exception $e) { // phpcs:ignore
} catch (Throwable) {
return $this->exceptionType();
}

Expand Down
3 changes: 2 additions & 1 deletion src/Type/Php/SimpleXMLElementConstructorThrowTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
use SimpleXMLElement;
use Throwable;
use function count;
use function extension_loaded;
use function libxml_use_internal_errors;
Expand Down Expand Up @@ -41,7 +42,7 @@ public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflect
foreach ($constantStrings as $constantString) {
try {
new SimpleXMLElement($constantString->getValue());
} catch (\Exception $e) { // phpcs:ignore
} catch (Throwable) {
return $methodReflection->getThrowType();
}

Expand Down
Loading