Skip to content

Add feature checks for Poster IP in Viewtopic and Print All Posts - #40

Merged
bonelifer merged 1 commit into
mainfrom
feature-checks-printallposts-posteripinviewtopic
Oct 28, 2026
Merged

bonelifer merged 1 commit into
mainfrom
feature-checks-printallposts-posteripinviewtopic

Conversation

@bonelifer

Copy link
Copy Markdown
Contributor

Adds feature_checks.py checks for two extensions:

  • phpbbmodders/posteripinviewtopic: gives the welcome post the address 203.0.113.7. It then checks that an administrator and a moderator of that forum only both see the IP and can look it up. A member without moderator permissions must neither see it nor be able to look it up (403). The lookup really calls ip-api.com, but only the status code is checked.
  • phpbbmodders/printallposts: adds a reply and an image attachment to the welcome topic, then sets one post per page. It checks the Print all link, that the Print all page shows both posts, and that it shows no attachments, as in phpBB's own print view.

Claude ran both against the extensions' master branches (2 failures, the bugs fixed in phpbbmodders/posteripinviewtopic and phpbbmodders/printallposts) and against the fix branches (11/11 passed).


Investigated and written by Claude on behalf of William Jacoby (bonelifer).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer
bonelifer merged commit ec98e30 into main Oct 28, 2026
1 check passed
@bonelifer
bonelifer deleted the feature-checks-printallposts-posteripinviewtopic branch October 28, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant