Repository navigation
Refresh the news page layout, add a lead image setting - #3
Merged
Merged
Conversation
Each news item shows its title, a byline (author, date and forum), the text, and one footer line: "Read more" only when the text was shortened, the comment count in words, "View topic" and the back-to-top arrow. With "Show user information" on, the avatar, rank, post count and profile fields sit under the byline instead of in a side column; the post buttons sit next to the title. The same template and stylesheet serve phpBB 3.3 and 4.0. The old notice block (an event listener on the extension's own post template) and the stylesheet that hid the profile column are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The forum and month filters are plain dropdown buttons ("All forums",
"All months") that show the chosen value, with a muted count and a
"New" link per forum in the list. Under the bar, "Showing" lists each
active filter as a chip that removes it, plus "Clear filters" when both
are set. Unused CSS and the old news icon image are removed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new migration adds news_lead_image, off by default, with a checkbox in the ACP. When it is on, the news list shows the post's first image (a BBCode image or an image attachment, inline or in the attachment box) above the text and takes it out of the text, with any line breaks that followed it. A single news item still shows the whole post. The image search lives in lead_image.php and has its own tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The single news page no longer repeats the title in the card or shows the filters. An "All news" link above the heading goes back to the list, and the footer offers "Reply" to readers who may reply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gallery now shows the news page with the lead image, filtered by forum, with poster information and buttons, shortened without the lead image, without filters, a single news item, the ACP and the phone layout. The README's feature list describes the new layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the news page's layout. It's the same on phpBB 3.3 and 4.0, using the extension's own template and stylesheet and nothing 4.0-only.
News items
Filters
Lead image (new setting, off by default)
news_lead_image, with an ACP checkbox: "Show the first image above the news".lead_image.php, with its own tests (smilies, linked images, attachment blocks, entities). A single news item still shows the whole post.Single news item
Removed
New and changed language strings are in English and German. README's feature list and the screenshot gallery are updated; the screenshots come from phpbbmodders/phpbb-release-tools#34.
Testing
Claude ran:
template_a11y.py: no findings.Not covered: the new layout with styles other than prosilver.
Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code