Repository navigation
Add plain-text copying for code blocks - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code blocks gain a separate Copy code button beside Select all. It copies plain text with whitespace preserved, supports Enter and Space, and provides localized success and failure feedback. If clipboard access fails, the code is selected for manual copying.
Codex verified phpBB 3.3 and 4.0 in both link-format modes, repeated activation, multiple blocks, keyboard focus, a 320-pixel viewport, fallback and recovery, and a real clipboard write/read. EPV reported no findings; PHP/JavaScript syntax, PHP coding standards, template checks, and ACP security probes passed. The new controls had no axe violations. Orca generated the expected status messages, with one reader selection-event exception on phpBB 4.0; audio playback was disabled.
Includes a separate dated update gallery, a reproducible capture script using the shared screenshot tool, and release-archive exclusions for the dated images.
Investigated and written by Codex on behalf of William Jacoby (bonelifer).