Repository navigation
Add Admin Activation Details for phpBB 3.3 and 4.0 - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpBB's administrator activation emails do not include the account's registration IP, email address, or registration date. Admin Activation Details adds those fields and WHOIS/RDAP and Stop Forum Spam lookup links through the existing email-rendering event, covering registrations and activation resends without core edits.
The extension preserves phpBB's recipients, activation links, notification preferences and queuing behavior. It includes reusable regression tests, synthetic email samples, a screenshot gallery, and CI for phpBB 3.3.x and master on PHP 8.3 and 8.4.
Codex verified both branches with 8 unit tests and 42 assertions each, plus real browser registration, resends, IPv4/IPv6, invalid-IP handling, queued delivery, administrator activation, and disable/re-enable checks. Local EPV and coding-standard checks passed. The extension-validation skill found no security or localization blockers; this remains a development build.
Investigated and written by Codex on behalf of William Jacoby (bonelifer).