715: fix private repo downloads - #717
Merged
Merged
Conversation
The easy route to use `browser_download_url` to grab the asset only works if the repo is a public repo. However, the docs do indeed say: - If within a browser, fetch the location specified in the `browser_download_url` key provided in the response. - Alternatively, set the `Accept` header of the request to `application/octet-stream`. The API will either redirect the client to the location, or stream it directly if possible. API clients should handle both a `200` or `302` response. So, we'll update PIE to use `url` and handle the other complexity with this. ref: https://docs.github.com/en/rest/releases/assets?apiVersion=2026-03-10#get-a-release-asset
…back from PackageReleaseAssets implementors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #715
PR submitter checklist