Fix private GitHub release asset downloads - #716
Conversation
|
@dbalabka as per the label on #715 please do not submit PRs without checking first, this is already being worked on and you have duplicated effort and wasted your own time. In future please read the maintainer's guide, which very clearly states this; additionally, if you had read the PR template you would've seen this also. |
|
@asgrim thanks for the quick response and for explaining why the PR was closed. I made this quick fix in order to move forward with my project. So, I submitted the PR as a draft mainly to demonstrate the cause of the problem and the possible approach to work around it. It is still left to properly pass the autentification token and use proper URL to allow download the asset. Please feel free to use it as a reference or inspiration if it is useful. There is no concern about duplicated effort on my side. I understand that the maintainers will likely implement a more precise and appropriate fix. Thanks again for the clarification. |
Summary
Fixes #715.
Verification