Repository navigation
Conversation
ndossche
requested changes
Nov 1, 2026
| wchar_t ps_buffer_w[MAX_PATH]; | ||
| char *tmp; | ||
|
|
||
| if (!(ps_buffer_cur_len = GetConsoleTitleW(ps_buffer_w, (DWORD)sizeof(ps_buffer_w)))) { |
Member
There was a problem hiding this comment.
I prefer this such that the length of the buffer is only spelled out once:
Suggested change
| if (!(ps_buffer_cur_len = GetConsoleTitleW(ps_buffer_w, (DWORD)sizeof(ps_buffer_w)))) { | |
| if (!(ps_buffer_cur_len = GetConsoleTitleW(ps_buffer_w, (DWORD)(sizeof(ps_buffer_w) / sizeof(ps_buffer_w[0]))))) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_ps_title()passedsizeof(ps_buffer_w)toGetConsoleTitleW(), butnSizeis a count of characters, not bytes. That told the API the 260-wchar_tbuffer could hold 520 characters, so a console title of 260 or more characters set by another process overflowed the stack buffer. This passesMAX_PATH, the buffer's real length, so long titles get truncated instead.No test, since it needs a console title longer than PHP itself allows to set, which another process has to set on the same console.
Fixes #25009