Repository navigation
Conversation
Where zend_long is not wider than an int, ZEND_LONG_UINT_OVFL() was defined as 0, so a negative value passed the check there, while it is rejected where zend_long is wider. Keep checking the lower bound on these platforms too. This affects mbstring.regex_stack_limit, mbstring.regex_retry_limit and the codepage of sapi_windows_cp_set() and sapi_windows_cp_conv().
marc-mabe
requested review from
LamentXU123,
alexdowad,
bukka and
youkidearitai
as code owners
October 27, 2026 10:28
The fix of ZEND_LONG_UINT_OVFL() on 32-bit platforms also makes Phar::buildFromIterator() reject a negative timestamp there.
marc-mabe
force-pushed
the
fix-zend-long-uint-ovfl-32bit-8.6
branch
from
October 27, 2026 10:34
eeff408 to
214d535
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix of #24778 also makes Phar::buildFromIterator() reject a negative timestamp there targeting 8.6
This is based on #24778 (cherry-picked)
This is split from #23688