Repository navigation
Conversation
Keep the existing expectations for older ICU releases and add ICU 79.1 variants for Portuguese GMT offset formatting and the Canadian Pacific Standard Time mapping.
LamentXU123
approved these changes
Oct 25, 2026
devnexen
approved these changes
Oct 25, 2026
Member
|
@devnexen To prevent us stepping onto each other's foot, I will wait for you to merge it ;) |
Member
|
Thanks ! |
kairosci
changed the title
Member
|
This should also be backported to 8.4. I will Backport it. |
LamentXU123
added a commit
that referenced
this pull request
Oct 25, 2026
* PHP-8.6: Backport: Adapt intl timezone test expectations for ICU 79.1 (#24684)
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 25, 2026
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 25, 2026
* PHP-8.4: Backport: Adapt intl timezone test expectations for ICU 79.1 (php#24684)
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 25, 2026
* PHP-8.5: Backport: Adapt intl timezone test expectations for ICU 79.1 (php#24684)
arnaud-lb
added a commit
to prateekbhujel/php-src
that referenced
this pull request
Oct 27, 2026
* PHP-8.4: (26 commits) Fix phpGH-24695: FPM tester sends signal to process group when PID is missing (php#24698) Fix phpGH-24605: Guard var_export() against native stack overflow (php#24671) Fix use-after-free of CURLOPT_STDERR stream on cloned curl handle IR: Backport code buffer rollback fix Fix SQL test on Windows (php#24755) Fix phpGH-24697: cli: passing PHP_HTTP_PARSER_STRICT build option doesn't work Fix phpGH-24438: Preserve indirect types in JIT side traces Fix phpGH-17733: System entropy does not take into account function order, resulting in wrong functions possibly called in different configurations Fix unmapping of an unrelated range when the aligned chunk mmap fails (php#24542) Backport: Adapt intl timezone test expectations for ICU 79.1 (php#24724) Tracing JIT: keep the SEND_VAL type guard after assigning to a reference Backport: Adapt intl timezone test expectations for ICU 79.1 (php#24684) ext/zip: Reject broken libzip versions on Windows (php#24371) ext/zip: Exclude broken libzip 1.12 (php#24358) Fix phpGH-24264: Unwind/GracefulExit discarded in spl_iterators.c phpdbg: Backport watchpoint fixes to PHP-8.4 Fix JIT reading packed-turned-hash array as packed after string key write ext/standard: Skip proc_open descriptor 0 tests without /proc/self/fd symlinks JIT: Fix operand type check in zend_redo_pass_two_ex() (php#24658) Fix error paths in dom_xml_serializing_a_document_node() ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS runner now installs ICU 79.1, causing three intl tests to fail because their expected output reflects older ICU data. Portuguese full date formatting now uses
+03:00 GMT, and the Canadian mapping for WindowsPacific Standard Timenow returnsAmerica/Los_Angeles.Add ICU 79.1 test variants and limit the existing variants to older releases, retaining exact output checks. The observed changes are recorded in the failing macOS job.
Validation: related intl tests on a debug ZTS build with ICU 78.3 passed (5 passed, 7 skipped for other ICU versions). The new ICU 79.1 expectations were checked against the CI differences, and version selection was checked across the release boundary. ICU 79.1 execution remains for CI.