Skip to content

dba: fix GH-24641 (NULL dereferencement with ndbm backend) #24652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Girgias wants to merge 1 commit into from
Closed

dba: fix GH-24641 (NULL dereferencement with ndbm backend) #24652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/dba/dba_ndbm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ DBA_OPEN_FUNC(ndbm)
}

dbf = dbm_open(ZSTR_VAL(info->path), gmode, filemode);
if (dbf == NULL) {
return FAILURE;
}

pinfo->dbf = dbf;
return SUCCESS;
Expand Down
30 changes: 30 additions & 0 deletions ext/dba/tests/gh24641.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
--TEST--
GH-24641 (ndbm backend never checks dbm_open() return value, NULL deref on first use after a failed open)
--EXTENSIONS--
dba
--FILE--
<?php

file_put_contents(__DIR__ . '/gh24641', 'not a valid ndbm/gdbm database, just plain text');

foreach (dba_handlers() as $handler) {
/* Suppress warnings */
$db = @dba_open(__DIR__ . '/gh24641', 'r', $handler);
/* Expected as this file is not a proper db file */
if ($db === false) {
continue;
}
/* Some drivers just don't care */
dba_firstkey($db); // SEGV
dba_close($db);
}

?>
DONE
--CLEAN--
<?php
@unlink(__DIR__ . '/gh24641');
@unlink(__DIR__ . '/gh24641-lock');
?>
--EXPECT--
DONE
Loading