Repository navigation
JIT: Fix OP_DATA leak when ASSIGN_DIM fails #24581
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| --TEST-- | ||
| JIT ASSIGN_DIM: OP_DATA is freed when appending to a full array fails | ||
| --INI-- | ||
| opcache.enable=1 | ||
| opcache.enable_cli=1 | ||
| opcache.file_update_protection=0 | ||
| opcache.jit=function | ||
| --EXTENSIONS-- | ||
| opcache | ||
| --FILE-- | ||
| <?php | ||
| class D { | ||
| function __destruct() { | ||
| echo "dtor\n"; | ||
| } | ||
| } | ||
|
|
||
| function test() { | ||
| $a = [PHP_INT_MAX => 1]; | ||
| $a[] = new D; | ||
| } | ||
|
|
||
| try { | ||
| test(); | ||
| } catch (Throwable $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } | ||
| ?> | ||
| --EXPECT-- | ||
| dtor | ||
| Error: Cannot add element to the array as the next element is already occupied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| JIT ASSIGN_DIM: OP_DATA is freed when a float key conversion throws | ||
| --INI-- | ||
| opcache.enable=1 | ||
| opcache.enable_cli=1 | ||
| opcache.file_update_protection=0 | ||
| opcache.jit=function | ||
| --EXTENSIONS-- | ||
| opcache | ||
| --FILE-- | ||
| <?php | ||
| class D { | ||
| function __destruct() { | ||
| echo "dtor\n"; | ||
| } | ||
| } | ||
|
|
||
| set_error_handler(function ($errno, $errstr) { | ||
| throw new Exception($errstr); | ||
| }); | ||
|
|
||
| function test() { | ||
| $a[1.5] = new D; | ||
| } | ||
|
|
||
| try { | ||
| test(); | ||
| } catch (Throwable $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } | ||
| ?> | ||
| --EXPECT-- | ||
| dtor | ||
| Exception: Implicit conversion from float 1.5 to int loses precision |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| JIT ASSIGN_DIM: OP_DATA is freed when a resource key conversion throws | ||
| --INI-- | ||
| opcache.enable=1 | ||
| opcache.enable_cli=1 | ||
| opcache.file_update_protection=0 | ||
| opcache.jit=function | ||
| --EXTENSIONS-- | ||
| opcache | ||
| --FILE-- | ||
| <?php | ||
| class D { | ||
| function __destruct() { | ||
| echo "dtor\n"; | ||
| } | ||
| } | ||
|
|
||
| set_error_handler(function ($errno, $errstr) { | ||
| throw new Exception($errstr); | ||
| }); | ||
|
|
||
| function test() { | ||
| $a[STDIN] = new D; | ||
| } | ||
|
|
||
| try { | ||
| test(); | ||
| } catch (Throwable $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| dtor | ||
| Exception: Resource ID#%d used as offset, casting to integer (%d) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| JIT ASSIGN_DIM: OP_DATA is freed once when a float key conversion throws on a false container | ||
| --INI-- | ||
| opcache.enable=1 | ||
| opcache.enable_cli=1 | ||
| opcache.file_update_protection=0 | ||
| opcache.jit=function | ||
| --EXTENSIONS-- | ||
| opcache | ||
| --FILE-- | ||
| <?php | ||
| set_error_handler(function ($errno, $errstr) { | ||
| if (!str_starts_with($errstr, "Automatic conversion of false")) { | ||
| throw new Exception($errstr); | ||
| } | ||
| }); | ||
|
|
||
| function id($x) { | ||
| return $x; | ||
| } | ||
|
|
||
| function test($o) { | ||
| $a = false; | ||
| $a[1.5] = id($o); | ||
| } | ||
|
|
||
| try { | ||
| test(new stdClass); | ||
| } catch (Exception $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } | ||
| ?> | ||
| --EXPECT-- | ||
| Exception: Implicit conversion from float 1.5 to int loses precision |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| JIT ASSIGN_DIM: OP_DATA is freed once when a resource key conversion throws on a false container | ||
| --INI-- | ||
| opcache.enable=1 | ||
| opcache.enable_cli=1 | ||
| opcache.file_update_protection=0 | ||
| opcache.jit=function | ||
| --EXTENSIONS-- | ||
| opcache | ||
| --FILE-- | ||
| <?php | ||
| set_error_handler(function ($errno, $errstr) { | ||
| if (!str_starts_with($errstr, "Automatic conversion of false")) { | ||
| throw new Exception($errstr); | ||
| } | ||
| }); | ||
|
|
||
| function id($x) { | ||
| return $x; | ||
| } | ||
|
|
||
| function test($o) { | ||
| $a = false; | ||
| $a[STDIN] = id($o); | ||
| } | ||
|
|
||
| try { | ||
| test(new stdClass); | ||
| } catch (Exception $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| Exception: Resource ID#%d used as offset, casting to integer (%d) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to move the execute_data and opline loads to the
!retvalerror path IMO. To deal withoplinechanging, then check for an exception and useEG(opline_before_exception).Same remark for the other helper