Repository navigation
ext/gmp: Use fast ZPP for several remaining functions - #24469
Closed
LamentXU123 wants to merge 1 commit into
Closed
LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
Member
|
The main reason I had converted those to fast ZPP was to migrate them to use a custom fast ZPP specifier. There is no need here. |
Member
Author
|
Ain't fast ZPP (slightly) faster and more readable? |
Member
|
At the cost of increased binaries as the whole logic is duplicated. I really don't have any strong opinions here. |
Member
Author
|
Some function like gmp_random_bits isn't taking much time to run itself esp when the argument is small. The ZPP stuff here can cause improvements. e.g. my local bench shows gmp_random_bits(1) ~17.4% less runtime. |
Member
Author
|
Okay I am closing this as the trade-off is not obvious, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up 9ee1265