Repository navigation
Conversation
henderkes
requested review from
TimWolla,
bukka and
kocsismate
as code owners
October 15, 2026 19:56
henderkes
marked this pull request as draft
October 15, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #24301
also closes #24262
@ndossche still not a guarantee that things will work, but brings 8.6's tls size back to 8.5's.
The php_md5_crypt_r change is worth another look because it seems the out parameter isn't used, so I don't know what it even exists for. But it's alive long enough that we can use that instead of abusing thread storage for a local symbol there.
I definitely favour the other solution, because we're just delaying the inevitable here.