Repository navigation
Conversation
TimWolla
changed the title
TimWolla
commented
Oct 15, 2026
| function sodium_crypto_xof_shake128_init(?int $domain = null): SodiumCryptoXofShake128State {} | ||
|
|
||
| function sodium_crypto_xof_shake128_update(string &$state, string $message): true {} | ||
| function sodium_crypto_xof_shake128_update(SodiumCryptoXofShake128State $state, string $message): void {} |
Member
Author
There was a problem hiding this comment.
Should $message also have #[\SensitiveParameter]?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ndossche
reviewed
Oct 15, 2026
ndossche
reviewed
Oct 15, 2026
TimWolla
force-pushed
the
sodium-xof-opaque
branch
from
October 16, 2026 08:18
1ae4cac to
0f9e704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #24182.