Repository navigation
Conversation
The nul handle was opened without security attributes, making it non-inheritable. It was then passed to CreateProcess() via STARTF_USESTDHANDLES, where the child cannot use a non-inheritable handle. Use php_proc_open_security so the handle is inheritable, like the pipe handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
proc_open()with a['null']descriptor opensnulviaCreateFileA()with NULL security attributes. The handle is therefore not inheritable, yet it is passed toCreateProcessW()throughSTARTF_USESTDHANDLES. The child gets an invalid std handle.The pipe handles already use
php_proc_open_security. This change uses it fornultoo, so the handle is inherited.This has been wrong since the null descriptor was added (6285bb52faf), but it only showed up once
proc_open_null.phptandproc_open_redirect.phptstarted running the child php with TEST_PHP_EXTRA_ARGS (GH-11669).Fixes failing CI.