Repository navigation
Conversation
ndossche
reviewed
Oct 24, 2026
Comment on lines
+798
to
+802
| if (exception && zend_is_unwind_exit(EG(exception))) { | ||
| OBJ_RELEASE(exception); | ||
| } else { | ||
| zend_exception_set_previous(EG(exception), exception); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (exception && zend_is_unwind_exit(EG(exception))) { | |
| OBJ_RELEASE(exception); | |
| } else { | |
| zend_exception_set_previous(EG(exception), exception); | |
| } | |
| zend_exception_set_previous(EG(exception), exception); |
This should work, no ? zend_exception_set_previous already handled an unwind exit the same way. Or am I missing something?
Member
Author
There was a problem hiding this comment.
My changes predated the set_previous change from the bailout fix. Now your suggestion works :)
Fix php#24265 A destroyed fiber swallowed UnwindExit along with the GracefulExit used to unwind it, so exit() in a finally block or destructor was lost. Only the GracefulExit is swallowed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #24265
A destroyed fiber swallowed UnwindExit along with the GracefulExit used to unwind it, so exit() in a finally block or destructor was lost. Only the GracefulExit is swallowed now.