Skip to content

sapi/phpdbg: remove dead str_type assignments before goto #22600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorgsowa wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −18
Open

sapi/phpdbg: remove dead str_type assignments before goto #22600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions sapi/phpdbg/phpdbg_bp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,33 +1500,24 @@ PHPDBG_API void phpdbg_print_breakpoints(zend_ulong type) /* {{{ */
switch (brake->type) {
case PHPDBG_BREAK_METHOD_OPLINE:
str_type = "method";
goto print_opline;
break;
case PHPDBG_BREAK_FUNCTION_OPLINE:
str_type = "function";
goto print_opline;
break;
case PHPDBG_BREAK_FILE_OPLINE:
str_type = "method";

print_opline: {
if (brake->type == PHPDBG_BREAK_METHOD_OPLINE) {
str_type = "method";
} else if (brake->type == PHPDBG_BREAK_FUNCTION_OPLINE) {
str_type = "function";
} else if (brake->type == PHPDBG_BREAK_FILE_OPLINE) {
str_type = "file";
}

phpdbg_writeln("#%d\t\t#"ZEND_ULONG_FMT"\t\t(%s breakpoint)%s",
brake->id, brake->opline, str_type,
((phpdbg_breakbase_t *) brake)->disabled ? " [disabled]" : "");
} break;
str_type = "file";
break;

default:
phpdbg_writeln("#%d\t\t#"ZEND_ULONG_FMT"%s",
brake->id, brake->opline,
((phpdbg_breakbase_t *) brake)->disabled ? " [disabled]" : "");
break;
continue;
}

phpdbg_writeln("#%d\t\t#"ZEND_ULONG_FMT"\t\t(%s breakpoint)%s",
brake->id, brake->opline, str_type,
((phpdbg_breakbase_t *) brake)->disabled ? " [disabled]" : "");
} ZEND_HASH_FOREACH_END();
} break;

Expand Down
Loading