Elide ZEND_VERIFY_RETURN_TYPE when returning $this if possible#21948
Open
Girgias wants to merge 4 commits intophp:masterfrom
Open
Elide ZEND_VERIFY_RETURN_TYPE when returning $this if possible#21948Girgias wants to merge 4 commits intophp:masterfrom
Girgias wants to merge 4 commits intophp:masterfrom
Conversation
Girgias
force-pushed
the
elide-return-type-check-for-this-with-static
branch
from
e874ad3 to
bf784bd
Compare
Girgias
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the most sensible approach, I would expect this to be profitable.
Maybe we can extend this to type checks of instances of the current class so that it coversDoneselftypes that are resolved at compile time.Maybe the test should also be more somewhere more appropriate?