Skip to content

ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >> #21945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LamentXU123 wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −3
Open

ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >> #21945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ PHP NEWS
. gmp_fact() reject values larger than unsigned long. (David Carlier)
. gmp_pow/binomial/root/rootrem and shift/pow operators reject values
larger than unsigned long. (David Carlier)
. GMP exponentiation and shift operators now emit a deprecation warning
when converting a float right operand to int loses precision. (Weilin Du)

- Hash:
. Upgrade xxHash to 0.8.2. (timwolla)
Expand Down
5 changes: 5 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ PHP 8.6 UPGRADE NOTES
4. Deprecated Functionality
========================================

- New warnings and exceptions:
. The shift (<<, >>) and exponentiation (**) operators on GMP objects now
emit a deprecation warning when converting a float right operand to int
loses precision.

- Mbstring:
. Mbregex has been deprecated, because the underlying Oniguruma library
is no longer maintained.
Expand Down
6 changes: 3 additions & 3 deletions ext/gmp/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,11 +332,11 @@ static zend_result shift_operator_helper(gmp_binary_ui_op_t op, zval *return_val

if (UNEXPECTED(Z_TYPE_P(op2) != IS_LONG)) {
if (UNEXPECTED(!IS_GMP(op2))) {
// For PHP 8.3 and up use zend_try_get_long()
bool failed;
switch (Z_TYPE_P(op2)) {
case IS_DOUBLE:
shift = zval_get_long(op2);
if (UNEXPECTED(EG(exception))) {
shift = zval_try_get_long(op2, &failed);
if (UNEXPECTED(failed)) {
return FAILURE;
}
break;
Expand Down
6 changes: 6 additions & 0 deletions ext/gmp/tests/overloading_with_float_fractional.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ object(GMP)#2 (1) {
["num"]=>
string(1) "0"
}

Deprecated: Implicit conversion from float 42.5 to int loses precision in %s on line %d
object(GMP)#2 (1) {
["num"]=>
string(69) "150130937545296572356771972164254457814047970568738777235893533016064"
Expand All @@ -122,10 +124,14 @@ object(GMP)#2 (1) {
["num"]=>
string(1) "0"
}

Deprecated: Implicit conversion from float 42.5 to int loses precision in %s on line %d
object(GMP)#2 (1) {
["num"]=>
string(15) "184717953466368"
}

Deprecated: Implicit conversion from float 42.5 to int loses precision in %s on line %d
object(GMP)#2 (1) {
["num"]=>
string(1) "0"
Expand Down
Loading