Skip to content

Additional SNMP library output formatting options #21502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eskyuu wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Additional SNMP library output formatting options #21502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3af51ed
Add functions to control more SNMP library output options (#21502)
eskyuu Mar 19, 2026
00f7b3a
Convert all boolean options to use bool type and rename variables
eskyuu Jul 11, 2026
e6b1a22
Change all function definitions that return SUCCESS/FAILURE to have a…
eskyuu Jul 11, 2026
498c67b
Fix syntax error
eskyuu Jul 11, 2026
de21350
Update php_snmp_write_t and php_snmp_read_t to be defined as zend_result
eskyuu Jul 11, 2026
a468bbf
Found anohter zend_result
eskyuu Jul 11, 2026
cb1cdfb
Update stub hash
eskyuu Aug 20, 2026
5e01bc7
Convert functions to accept enums instead of constants
eskyuu Aug 20, 2026
4d3bed2
Fix indentation and revert SNMP_VALUE_* constants
eskyuu Aug 20, 2026
1711176
Include zend enum header
eskyuu Aug 20, 2026
fecfc96
Fix typo
eskyuu Aug 20, 2026
e026efc
Fix escaping \ characters in strings
eskyuu Aug 20, 2026
e32190d
Reverse changes to the SNMP_OID_OUTPUT_* constants
eskyuu Aug 20, 2026
d0b44e2
Re-convert snmp_set_string_output_format() to use the ENUM, with a fa…
eskyuu Aug 20, 2026
a40ef2e
Add new methods to set the OID and String output on the SNMP class us…
eskyuu Aug 20, 2026
6992bf7
Update test output for snmp_set_oid_output_format()
eskyuu Aug 20, 2026
48ad3f6
Swap the string and oid output logic to allow the legacy function to …
eskyuu Aug 20, 2026
215d165
Fix typo and error output
eskyuu Aug 20, 2026
79547a6
Update SNMP OO test
eskyuu Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ext/snmp/php_snmp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,18 @@ typedef struct _php_snmp_object {
struct snmp_session *session;
int max_oids;
int valueretrieval;
int quick_print;
int enum_print;
bool quick_print;
bool enum_print;
bool numeric_index;
bool numeric_timeticks;
bool extended_index;
bool dont_print_units;
bool escape_quotes;
bool print_hex_text;
int string_output_format;
int oid_output_format;
int snmp_errno;
int oid_increasing_check;
bool oid_increasing_check;
int exceptions_enabled;
char snmp_errstr[256];
zend_object zo;
Expand All @@ -60,8 +67,8 @@ typedef struct _php_snmp_object {

#define Z_SNMP_P(zv) php_snmp_fetch_object(Z_OBJ_P((zv)))

typedef int (*php_snmp_read_t)(php_snmp_object *snmp_object, zval *retval);
typedef int (*php_snmp_write_t)(php_snmp_object *snmp_object, zval *newval);
typedef zend_result (*php_snmp_read_t)(php_snmp_object *snmp_object, zval *retval);
typedef zend_result (*php_snmp_write_t)(php_snmp_object *snmp_object, zval *newval);

typedef struct _ptp_snmp_prop_handler {
const char *name;
Expand Down
Loading
Loading