Repository navigation
Minor refactoring of basic functions - #20618
Merged
Merged
Conversation
Girgias
force-pushed
the
basic-fns-minor-refactor
branch
from
November 29, 2025 17:38
44db3e5 to
973c0a7
Compare
Girgias
marked this pull request as ready for review
November 29, 2025 17:38
Girgias
force-pushed
the
basic-fns-minor-refactor
branch
from
April 6, 2026 18:13
973c0a7 to
96e1350
Compare
ndossche
approved these changes
Oct 14, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
I feel like I at some point already looked at this
| { | ||
| ZEND_PARSE_PARAMETERS_NONE(); | ||
|
|
||
| RETURN_LONG(PG(connection_status) & PHP_CONNECTION_ABORTED); |
Member
There was a problem hiding this comment.
Technically, this change can break user code that checks the return value against PHP_CONNECTION_ABORTED
…_user_abort() The INI setting is stored and displayed as a bool already.
Girgias
force-pushed
the
basic-fns-minor-refactor
branch
from
October 17, 2026 12:31
96e1350 to
7f88327
Compare
Member
Author
Yeah because other people did PRs that handled the same I did in some commits here. Rebased on latest master that drops the changes which already landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed in order.