Fix rendering of class method names inside packagesynopsis#251
Open
kocsismate wants to merge 1 commit intophp:masterfrom
Open
Fix rendering of class method names inside packagesynopsis#251kocsismate wants to merge 1 commit intophp:masterfrom
kocsismate wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
Sorry, don't think I can review this, as I understand absolutely nothing about this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering of method names inside
packagesynopsistags were broken, because the the code relied on having the FQCN inside the classname tag, but this isn't the case anymore for classes inside apackagesynopsistag.Tests are TBD.
A printscreen about a namespaced class for evidence:
And another one for a non-namespaced class: