Support the z coordinate when following spatial audio sources - #7369
Open
ICOM725 wants to merge 1 commit into
Open
Support the z coordinate when following spatial audio sources#7369ICOM725 wants to merge 1 commit into
ICOM725 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
Follow the source object's optional
zcoordinate when updating a spatial sound, including zero and negative values. Keep the existing depth whenzis absent or undefined, and document thatfollowaccepts aVector3Likeobject.Add regression coverage for changing coordinates, zero depth, two-dimensional targets, undefined depth, paused playback and unchanged coordinates. This change is limited to following a source; it does not add a new
WebAudioSound.zaccessor.Fixes #7135.
Validation:
lines-around-commentdisabled. Without that override, the existing test at line 321 fails the same rule on both the baseline and this branch.git diff --checkpassed.The JSDoc
-Xcheck could not complete because the installed JSDoc 3 callsutil.isRegExp, which is unavailable in Node 25. No dependency changes or generated files are included.