Fix leftButtonReleased reporting presses as releases - #7367
Open
ICOM725 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
leftButtonReleased()currently returnstrueon a left-button press because its nonzerobuttonsbranch only checksbutton. Check that the left button is no longer held in that branch, while preserving release detection when another mouse button remains pressed.Adds seven tests covering left-button presses and releases, left/right button combinations, releases of another button, and touch start/end.
Fixes #7254.
Verification:
npm test -- tests/input --maxWorkers=2: 24 files and 656 tests passed.npm run build: webpack compiled successfully; the copy-to-examples step reported that the sibling examples directory was absent.npm run lintcould not load the repository's legacy JSON config with ESLint 10 (ERR_IMPORT_ATTRIBUTE_MISSING). Targeted ESLint 8 checking found one pre-existinglines-around-commenterror inPointer.test.js; the same check passed with that rule disabled.git diff --checkpassed.