Fix polygon stroke vertex deduplication - #7362
Open
ICOM725 wants to merge 1 commit into
Open
Conversation
ICOM725
marked this pull request as ready for review
September 7, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
Compare consecutive stroke vertices in the same coordinate space. The existing check compares the current origin-adjusted vertex with the previous unadjusted vertex, which can skip distinct corners or retain duplicate vertices when the display origin is non-zero.
Add regression tests for the centered diamond in #7361, consecutive duplicate vertices with zero and non-zero display origins, and open paths.
Fixes #7361.
Validation:
npm test -- tests/gameobjects/shape --maxWorkers=2: 320 tests passed.npm run build: webpack compilation passed; the optional copy-to-examples step reports a missing sibling examples directory.git diff --checkpassed.The repository's
npm run lintcommand fails to load its legacy JSON configuration with the installed ESLint 10 (ERR_IMPORT_ATTRIBUTE_MISSING). No dependency or lint configuration changes are included.