Skip to content

fix: RELOAD/RECONNECT broke automatic role detection temporarily#941

Merged
levkk merged 4 commits intomainfrom
levkk-fix-auto-role
Apr 28, 2026
Merged

fix: RELOAD/RECONNECT broke automatic role detection temporarily#941
levkk merged 4 commits intomainfrom
levkk-fix-auto-role

Conversation

@levkk
Copy link
Copy Markdown
Collaborator

@levkk levkk commented Apr 27, 2026

fix #927

  • fix: prevent concurrent RELOAD/RECONNECT
  • fix: TOCTOU in fast/subsequent RELOAD commands pausing clients indefinitely (pretty unlikely but clearly possible race condition)
  • fix: RELOAD/RECONNECT resets roles back to auto causing load balancer to send some writes to replicas

@blacksmith-sh

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

@levkk levkk marked this pull request as ready for review April 27, 2026 23:38
@levkk levkk merged commit 4addc25 into main Apr 28, 2026
23 checks passed
@levkk levkk deleted the levkk-fix-auto-role branch April 28, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent error: WARN new primary chosen

1 participant