Skip to content

build(win32): pin electron version from runtime/package.json instead of resolving latest in Make.bat #10413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dev-hari-prasad wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

build(win32): pin electron version from runtime/package.json instead of resolving latest in Make.bat #10413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Make.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,17 @@ REM Main build sequence Ends
REM Get a fresh copy of electron.

REM WGET
FOR /f "tokens=*" %%i IN ('npm info electron version') DO SET "ELECTRON_VERSION=%%i"
REM Resolve the electron version from runtime/package.json, NOT from
REM `npm info electron version`. The latter fetches whatever currently
REM carries the `latest` dist-tag on the npm registry, which means any
REM newly published electron release lands in shipped binaries without
REM review. Keep the build deterministic and pinned.
SET "ELECTRON_VERSION="
FOR /f "delims=" %%i IN ('node -p "(require(process.argv[1]).devDependencies?.electron || require(process.argv[1]).dependencies?.electron || '').replace(/^\^/, '')" "%WD%\runtime\package.json"') DO SET "ELECTRON_VERSION=%%i"
IF "%ELECTRON_VERSION%"=="" (
ECHO ERROR: Could not resolve Electron version from runtime/package.json.
EXIT /B 1
)

:GET_NW
wget https://github.com/electron/electron/releases/download/v%ELECTRON_VERSION%/electron-v%ELECTRON_VERSION%-win32-x64.zip -O "%TMPDIR%\electron-v%ELECTRON_VERSION%-win32-x64.zip"
Expand Down
Loading