Fix MAINTAIN privilege silently dropped for views/mviews on PG17+

web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/pg/17_plus/alter_mview.sql

@@ -0,0 +1,18 @@
+-- View: public.testmview_$%{}[]()&*^!/@`#
+
+-- DROP MATERIALIZED VIEW IF EXISTS public."testmview_$%{}[]()&*^!/@`#";
+
+CREATE MATERIALIZED VIEW IF NOT EXISTS public."testmview_$%{}[]()&*^!/@`#"
+TABLESPACE pg_default
+AS
+ SELECT 1 AS col1
+WITH NO DATA;
+
+ALTER TABLE IF EXISTS public."testmview_$%{}[]()&*^!/@`#"
+    OWNER TO <OWNER>;
+
+COMMENT ON MATERIALIZED VIEW public."testmview_$%{}[]()&*^!/@`#"
+    IS 'comment1';
+
+GRANT TRUNCATE, INSERT, DELETE, SELECT, TRIGGER, UPDATE, REFERENCES ON TABLE public."testmview_$%{}[]()&*^!/@`#" TO PUBLIC;
+GRANT ALL ON TABLE public."testmview_$%{}[]()&*^!/@`#" TO <OWNER>;

web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/pg/17_plus/alter_mview_change_grantee_priv.sql

@@ -0,0 +1,17 @@
+-- View: public.testmview_$%{}[]()&*^!/@`#
+
+-- DROP MATERIALIZED VIEW IF EXISTS public."testmview_$%{}[]()&*^!/@`#";
+
+CREATE MATERIALIZED VIEW IF NOT EXISTS public."testmview_$%{}[]()&*^!/@`#"
+TABLESPACE pg_default
+AS
+ SELECT 1 AS col1
+WITH NO DATA;
+
+ALTER TABLE IF EXISTS public."testmview_$%{}[]()&*^!/@`#"
+    OWNER TO <OWNER>;
+
+COMMENT ON MATERIALIZED VIEW public."testmview_$%{}[]()&*^!/@`#"
+    IS 'comment1';
+
+GRANT TRUNCATE, INSERT, DELETE, SELECT, TRIGGER, UPDATE, REFERENCES ON TABLE public."testmview_$%{}[]()&*^!/@`#" TO PUBLIC;

web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/pg/17_plus/alter_mview_change_grantee_priv_msql.sql

@@ -0,0 +1,2 @@
+REVOKE ALL ON TABLE public."testmview_$%{}[]()&*^!/@`#" FROM <OWNER>;
+GRANT INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES, TRIGGER ON TABLE public."testmview_$%{}[]()&*^!/@`#" TO PUBLIC;

web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/pg/17_plus/alter_mview_msql.sql

@@ -0,0 +1 @@
+GRANT INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES, TRIGGER ON TABLE public."testmview_$%{}[]()&*^!/@`#" TO PUBLIC;

web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/pg/17_plus/test_mview.json

@@ -0,0 +1,345 @@
+{
+  "scenarios": [
+    {
+      "type": "create",
+      "name": "Create Extension",
+      "endpoint": "NODE-extension.obj",
+      "sql_endpoint": "NODE-extension.sql_id",
+      "data": {
+        "name": "postgres_fdw",
+        "version": "",
+        "relocatable": true
+      },
+      "store_object_id": true
+    },
+    {
+      "type": "create",
+      "name": "Create Materialised Views with extensions.",
+      "endpoint": "NODE-mview.obj",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql",
+      "data": {
+        "spcname": "pg_default",
+        "schema": "public",
+        "owner": "<OWNER>",
+        "datacl": [],
+        "seclabels": [],
+        "name": "testmview_$%{}[]()&*^!/@`#",
+        "comment": "comment1",
+        "definition": "SELECT 1 AS col1",
+        "dependsonextensions": [
+          "plpgsql",
+          "postgres_fdw"
+        ]
+      },
+      "expected_sql_file": "create_mview_no_depends.sql",
+      "expected_msql_file": "create_mview_no_depends.msql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views with NO DEPENDS.",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "dependsonextensions": [
+          "plpgsql"
+        ]
+      },
+      "expected_sql_file": "alter_mview_no_depends.sql",
+      "expected_msql_file": "alter_mview_no_depends.msql"
+    },
+    {
+      "type": "delete",
+      "name": "Drop Materialised Views",
+      "endpoint": "NODE-mview.delete_id",
+      "data": {}
+    },
+    {
+      "type": "delete",
+      "name": "Drop Extension",
+      "endpoint": "NODE-extension.delete",
+      "data": {
+        "ids": [
+          "<postgres_fdw>"
+        ]
+      },
+      "preprocess_data": true
+    },
+    {
+      "type": "create",
+      "name": "Create Materialised Views",
+      "endpoint": "NODE-mview.obj",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql",
+      "data": {
+        "spcname": "pg_default",
+        "schema": "public",
+        "owner": "<OWNER>",
+        "datacl": [],
+        "seclabels": [],
+        "name": "testmview_$%{}[]()&*^!/@`#",
+        "comment": "comment1",
+        "definition": "SELECT 1 AS col1"
+      },
+      "expected_sql_file": "create_mview.sql",
+      "expected_msql_file": "create_mview_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (Adding privileges)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "datacl": {
+          "added": [
+            {
+              "grantee": "PUBLIC",
+              "grantor": "<OWNER>",
+              "privileges": [
+                {
+                  "privilege_type": "a",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "r",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "w",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "d",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "D",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "x",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "t",
+                  "privilege": true,
+                  "with_grant": false
+                }
+              ]
+            }
+          ]
+        }
+      },
+      "expected_sql_file": "alter_mview.sql",
+      "expected_msql_file": "alter_mview_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (Remove all privileges)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "datacl": {
+          "deleted": [
+            {
+              "grantee": "PUBLIC",
+              "grantor": "<OWNER>",
+              "privileges": [
+                {
+                  "privilege_type": "a",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "r",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "w",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "d",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "D",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "x",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "t",
+                  "privilege": true,
+                  "with_grant": false
+                }
+              ]
+            }
+          ]
+        }
+      },
+      "expected_sql_file": "alter_mview_drop_all_priv.sql",
+      "expected_msql_file": "alter_mview_drop_all_priv_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (change grantee in privileges)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "datacl": {
+          "changed": [
+            {
+              "grantee": "PUBLIC",
+              "grantor": "<OWNER>",
+              "old_grantee": "<OWNER>",
+              "privileges": [
+                {
+                  "privilege_type": "a",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "r",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "w",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "d",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "D",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "x",
+                  "privilege": true,
+                  "with_grant": false
+                },
+                {
+                  "privilege_type": "t",
+                  "privilege": true,
+                  "with_grant": false
+                }
+              ]
+            }
+          ]
+        }
+      },
+      "expected_sql_file": "alter_mview_change_grantee_priv.sql",
+      "expected_msql_file": "alter_mview_change_grantee_priv_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (change definition)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "definition": "SELECT 12 AS col1;"
+      },
+      "expected_sql_file": "alter_mview_definition.sql",
+      "expected_msql_file": "alter_mview_definition_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (Fillfactor)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "fillfactor": "18",
+        "with_data": true
+      },
+      "expected_sql_file": "alter_mview_add_fillfactor.sql",
+      "expected_msql_file": "alter_mview_add_fillfactor_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (add table parameters)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "autovacuum_custom": true,
+        "autovacuum_enabled": "t",
+        "vacuum_table": {
+          "changed": [
+            {
+              "name": "autovacuum_analyze_scale_factor",
+              "value": 0.2
+            }
+          ]
+        }
+      },
+      "expected_sql_file": "alter_mview_add_table_parameter.sql",
+      "expected_msql_file": "alter_mview_add_table_parameter_msql.sql"
+    },
+    {
+      "type": "alter",
+      "name": "Alter Materialised Views (remove table parameters)",
+      "endpoint": "NODE-mview.obj_id",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql_id",
+      "data": {
+        "autovacuum_custom": true,
+        "autovacuum_enabled": "x",
+        "vacuum_table": {
+          "changed": [
+            {
+              "name": "autovacuum_analyze_scale_factor",
+              "value": null
+            }
+          ]
+        }
+      },
+      "expected_sql_file": "alter_mview_remove_table_parameter.sql",
+      "expected_msql_file": "alter_mview_remove_table_parameter_msql.sql"
+    },
+    {
+      "type": "create",
+      "name": "Create Materialised Views with access method",
+      "endpoint": "NODE-mview.obj",
+      "sql_endpoint": "NODE-mview.sql_id",
+      "msql_endpoint": "NODE-mview.msql",
+      "data": {
+        "spcname": "pg_default",
+        "schema": "public",
+        "owner": "<OWNER>",
+        "datacl": [],
+        "seclabels": [],
+        "name": "testmview_am_$%{}[]()&*^!/@`#",
+        "comment": "comment1",
+        "definition": "SELECT 1 AS col1",
+        "amname": "heap"
+      },
+      "expected_msql_file": "create_mview_with_am_msql.sql",
+      "expected_sql_file": "create_mview_with_am.sql"
+    }
+  ]
+}