Skip to content

Removed sonarlint file - #168

Merged
petermcd merged 3 commits into
mainfrom
sq-removal
Sep 20, 2026
Merged

petermcd merged 3 commits into
mainfrom
sq-removal

Conversation

@petermcd

@petermcd petermcd commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Removed snarling file missed in previous pull.

Summary by Sourcery

Remove the obsolete SonarLint configuration and prepare the package for the 1.3.4 release.

Enhancements:

  • Remove the obsolete SonarLint connected-mode configuration.

Build:

  • Bump the package version to 1.3.4 and update the lockfile accordingly.

Documentation:

  • Update the changelog for the release.

@petermcd petermcd self-assigned this Sep 20, 2026
@petermcd petermcd added the enhancement New feature or request label Sep 20, 2026
Copilot AI lite review requested due to automatic review settings September 20, 2026 20:23
@sourcery-ai

sourcery-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the previously missed SonarLint configuration file and prepares the package for release 1.3.4 by updating the changelog and project version.

File-Level Changes

Change Details Files
Remove the repository’s SonarLint connected-mode configuration and update the package release metadata.
  • Delete the SonarLint connected-mode configuration.
  • Record the release changes in the changelog.
  • Bump the project version from 1.3.3 to 1.3.4.
.sonarlint/connectedMode.json
CHANGELOG.rst
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="pyproject.toml" line_range="3" />
<code_context>
 [project]
 name = "Monzo-API"
-version = "1.3.3"
+version = "1.3.4"
 authors = [{ name = "Peter McDonald", email = "git@petermcdonald.co.uk"}]
 description = "Package to interact with the API provided by Monzo bank"
</code_context>
<issue_to_address>
**issue (bug_risk):** `pyproject.toml` declares version 1.3.4 while `uv.lock` still records the editable `monzo-api` package as version 1.3.3, leaving the committed lockfile inconsistent with the project metadata. A lock-enforcing command such as `uv sync --locked` rejects the repository until the lockfile is regenerated.

**Triggers:** When a developer or CI job uses the committed lockfile in locked mode.

**Suggested fix:** Regenerate `uv.lock` after the version bump and commit the updated lockfile.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and the change removes a lint configuration and changes the package version, so it does not alter application data, access, or money movement. If the version is published incorrectly, that metadata persists in the released artifact and requires a follow-up release to correct, but reverting the repository change otherwise restores the prior behavior.

Blocking findings: pyproject.toml:3


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread pyproject.toml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Regenerate uv.lock and correct the two changelog nits.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Removes the obsolete SonarLint connected-mode configuration and prepares the package for version 1.3.4.

Changes:

  • Bumps the package version to 1.3.4.
  • Updates the changelog.
  • Deletes .sonarlint/connectedMode.json.
File Summary
pyproject.toml Updates the package version; uv.lock still requires regeneration for version consistency.
CHANGELOG.rst Documents the release; terminology and GitHub capitalization need correction.
.sonarlint/​connectedMode.json Removes the obsolete SonarLint connected-mode configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@petermcd
petermcd merged commit c5fb5f2 into main Sep 20, 2026
12 checks passed
@petermcd
petermcd deleted the sq-removal branch September 20, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants