Skip to content

Removed Sonarqube from Github actions - #167

Merged
petermcd merged 2 commits into
mainfrom
sq-removal
Sep 20, 2026
Merged

petermcd merged 2 commits into
mainfrom
sq-removal

Conversation

@petermcd

@petermcd petermcd commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Removing Sonarqube from GitHub actions as the server has been decommissioned.

Summary by Sourcery

Remove the decommissioned SonarQube checks from CI and release the package as version 1.3.3.

Enhancements:

  • Remove the retired SonarQube integration and its associated configuration from GitHub Actions.

CI:

  • Stop exporting SonarQube secrets and running SonarQube scans in the CI workflow.

Chores:

  • Bump the package version to 1.3.3 and update the lockfile and changelog.

@petermcd petermcd self-assigned this Sep 20, 2026
Copilot AI lite review requested due to automatic review settings September 20, 2026 19:59
@petermcd petermcd added the enhancement New feature or request label Sep 20, 2026
@sourcery-ai

sourcery-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes the decommissioned SonarQube workflow job, related secrets wiring, and project configuration, while incrementing the package version to 1.3.3 and updating the changelog.

File-Level Changes

Change Details Files
Remove the decommissioned SonarQube integration from CI configuration.
  • Delete global SonarQube token and host URL environment variables.
  • Remove the SonarQube scanning job and its checkout, scan action, matrix, and conditional execution.
  • Delete the SonarQube project configuration file.
.github/workflows/uv.yml
sonar-project.properties
Update the package release metadata for the new version.
  • Bump the project version from 1.3.2 to 1.3.3.
  • Add the corresponding changelog entries.
pyproject.toml
CHANGELOG.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="pyproject.toml" line_range="3" />
<code_context>
 [project]
 name = "Monzo-API"
-version = "1.3.2"
+version = "1.3.3"
 authors = [{ name = "Peter McDonald", email = "git@petermcdonald.co.uk"}]
 description = "Package to interact with the API provided by Monzo bank"
</code_context>
<issue_to_address>
**issue (bug_risk):** `pyproject.toml` now declares version `1.3.3`, but the tracked `uv.lock` still records the editable `monzo-api` package as version `1.3.2`; commands that validate the lockfile, such as `uv lock --check` or locked installs, reject the repository as out of date.

**Triggers:** When a consumer or CI job uses the committed lockfile in locked mode.

**Suggested fix:** Regenerate `uv.lock` after changing the project version.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and removing the SonarQube workflow and configuration changes the repository's CI quality and security-check coverage, so defects introduced while it is absent could be merged without detection and may outlive a revert. Restoring the workflow stops the gap, but it does not automatically identify or repair changes that passed during it.

Blocking findings: pyproject.toml:3


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread pyproject.toml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The tracked uv.lock still records monzo-api as version 1.3.2.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Removes the decommissioned SonarQube CI integration and prepares the package release as 1.3.3.

Changes:

  • Removes SonarQube workflow configuration.
  • Deletes sonar-project.properties.
  • Bumps the package version and updates the changelog.
File Description
sonar-project.properties Removes SonarQube project configuration.
pyproject.toml Updates the package version to 1.3.3.
CHANGELOG.rst Records the 1.3.3 release.
.github/​workflows/​uv.yml Removes SonarQube CI settings and job.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml
Comment thread CHANGELOG.rst
@petermcd
petermcd merged commit 418ceb4 into main Sep 20, 2026
12 checks passed
@petermcd
petermcd deleted the sq-removal branch September 20, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants