Repository navigation
feat(mobile): animate range-bearing sensor beam and sensing region - #858
Open
huxiaoyi-ovo wants to merge 2 commits into
Open
huxiaoyi-ovo wants to merge 2 commits into
huxiaoyi-ovo wants to merge 2 commits into
Conversation
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
| Security | 25 high |
🟢 Metrics 31 complexity · 0 duplication
Metric Results Complexity 31 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16867 16921 +54
=====================================
- Misses 16867 16921 +54 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #753.
Implement animated visualization for
RangeBearingSensor:poly_style, accounting for the robot pose, range limits, and angular field of view.line_style.Validation
mypy, documentation build, coverage and PR title checks passed.[Full CI results](https://github.com/huxiaoyi-ovo/robotics-toolbox-python/actions/runs/39250192578)
Behaviour changes
When
plot=True, the sensing region and observation beam are now rendered and updated. Sensor measurements and returned landmark IDs are unchanged.AI Assistance
ChatGPT (OpenAI GPT-6) assisted with implementation and regression tests. The changes were reviewed and validated before submission.