Repository navigation
fix(robot): qlim and printing work for a robot with symbolic parameters - #856
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
enabled auto-merge (squash)
October 19, 2026 08:22
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 373 complexity · 3 duplication
Metric Results Complexity 373 Duplication 3
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16866 16867 +1
=====================================
- Misses 16866 16867 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print(robot)androbot.qlimraisedTypeError: ufunc 'isnan' not supportedfor a robot made withsymbolic=True, for examplertb.models.DH.Puma560(symbolic=True). Found while renovatingsymbolic.ipynb.The
qlimproperty tested the joint limits withnp.isnan, which rejects the SymPy numbers a symbolic model holds. It now converts the limits to floats first. This does not change results for numeric models. A limit that is a free symbol still cannot be represented in the float array thatqlimreturns, and now raises the conversion error from NumPy.New
tests/test_symbolic_qlim.py(3 tests: the symbolic limits equal the numeric ones, a symbolic robot prints, and the default limits for an unset revolute joint). Full suite: only the 20test_servo_half_turnfailures from the stale compiled extension in my worktree; mypy clean. Written with AI assistance (Claude Code).🤖 Generated with Claude Code