Repository navigation
docs(notebooks): modernise icra2021.ipynb for the current API - #854
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
enabled auto-merge (squash)
October 19, 2026 08:16
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16866 16866
=====================================
Misses 16866 16866 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notebook renovation,
icra2021.ipynb(the code for the ICRA 2021 paper). It had 3 error cells against main; it now has none, and no warnings. No change to the toolbox.What changed
T.plot(label="2")is nowT.plot(frame="2")(trplottakesframe, in the released spatialmath too).ETS.tz(),ETS.rz()and so on are nowET.tz(),ET.Rz();ERobotisRobot.Box(..., base=...)is nowCuboid(..., pose=...)andcollidedisiscollided, which removes theFutureWarnings (both are in the released spatialgeometry 1.4.2).Executed headless against main: 0 error cells and no warnings from the toolbox. Not tried in a browser. Written with AI assistance (Claude Code).
🤖 Generated with Claude Code