Repository navigation
fix: narrow window title exception handling - #141
Merged
petercorke merged 3 commits intoOct 17, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
|
I'm going to hold off on this. #263 on spatialmath is a more solid fix, but like many of my PRs it's stuck in RAI's merge queue. |
Contributor
Author
|
Makes sense, Peter. #263 does look like the more solid fix. I will keep an eye on it and close this once it lands, or feel free to close it whenever suits you. |
Owner
|
But since they are so slow, maybe we go with this, it is correct, and fix it up whenever #263 lands. |
petercorke
approved these changes
Oct 17, 2026
Owner
|
Thanks, and for your patience while we sorted out #263. Merged as it is; we'll swap in the spatialmath helper when that lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the set_window_title part of #115.
Catch AttributeError and RuntimeError for backends without a usable window manager instead of swallowing every exception. Unexpected ValueError failures and KeyboardInterrupt now propagate.
Five headless tests cover normal title forwarding, the two tolerated backend failures, and the two propagated errors. The latter two fail on the original implementation.
Validation on Python 3.11:
Tests use a minimal window-manager adapter; no actual desktop GUI was opened. The full suite was not run on OpenCV 4. Other exception sites in #115 remain separate.