Repository navigation
fix: preserve unexpected peak refinement failures - #140
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
petercorke
approved these changes
Oct 17, 2026
petercorke
approved these changes
Oct 17, 2026
Owner
|
Thanks — turning the swallowed fit failure into a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the findpeaks.py part of #115.
Polynomial refinement now skips only ValueError and NumPy LinAlgError failures. It emits a RuntimeWarning, pointing to the caller, instead of printing to stdout. Unrelated exceptions and user interrupts are no longer swallowed.
Added a real boundary-neighbourhood regression and injected-error tests for RuntimeError and KeyboardInterrupt. All three assertions fail with the original bare except.
Validation on Python 3.11:
Full suite on OpenCV 4 was not run. Other exception sites in #115 are left to separate changes.